falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suhas Vasu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1003) Update checkstyle to remove DoubleCheckedLocking
Date Fri, 20 Feb 2015 07:16:12 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328644#comment-14328644
] 

Suhas Vasu commented on FALCON-1003:
------------------------------------

Minor nit.

The only changes in the *.properties are newline at EOF. Can we avoid unnecesary file changes
?

> Update checkstyle to remove DoubleCheckedLocking
> ------------------------------------------------
>
>                 Key: FALCON-1003
>                 URL: https://issues.apache.org/jira/browse/FALCON-1003
>             Project: Falcon
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Pallavi Rao
>            Assignee: Pallavi Rao
>            Priority: Trivial
>         Attachments: FALCON-1003-v2.patch, FALCON-1003-v3.patch, FALCON-1003-v4.patch,
FALCON-1003-v5.patch, FALCON-1003.patch
>
>
> As per, http://checkstyle.sourceforge.net/releasenotes.html, Release 5.6 onwards - "Removed
the DoubleCheckedLocking check, as in Java 5 (and beyond), using the volatile keyword addresses
the issue. See here for more details."
> Primary reason for removing this is, I couldn't load the existing checkstyle file in
my IntelliJ checkstyle plugin because DoubleCheckedLocking check was enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message