falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 31345: Add test in falcon to test touch feature
Date Tue, 24 Feb 2015 09:44:08 GMT


> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java,
line 601
> > <https://reviews.apache.org/r/31345/diff/1/?file=873531#file873531line601>
> >
> >     we can just pass "data" as param and use Util.readEntityName to get the name
inside.

Will make changes in the new patch


> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java,
line 99
> > <https://reviews.apache.org/r/31345/diff/1/?file=873533#file873533line99>
> >
> >     checking to bundle ID should be good enough. this check is not needed. Same
with the check in next line for waitTillInstanceAreCreated.

Will make changes in the new patch


> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java,
line 107
> > <https://reviews.apache.org/r/31345/diff/1/?file=873533#file873533line107>
> >
> >     validations till here are good enough. Below 3 line can be removed. They can
be removed from rest of the test as well.

Will make changes in the new patch


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/#review73775
-----------------------------------------------------------


On Feb. 24, 2015, 7:26 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31345/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 7:26 a.m.)
> 
> 
> Review request for Falcon and samarth gupta.
> 
> 
> Bugs: FALCON-1043
>     https://issues.apache.org/jira/browse/FALCON-1043
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
e11b37d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
5717923 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31345/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message