falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 30721: FeedReplicationTest modified to check for _SUCCESS getting created on target directory
Date Tue, 24 Feb 2015 08:49:28 GMT


> On Feb. 23, 2015, 7:19 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java,
line 144
> > <https://reviews.apache.org/r/30721/diff/1/?file=852101#file852101line144>
> >
> >     in remote case it might be possible that file name may contain "_SUCCESS" .
Its better to check for exact name, since we are sure it should be _SUCCESS.

Adding check for file name itself instead of checking a part of it


> On Feb. 23, 2015, 7:19 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java,
line 145
> > <https://reviews.apache.org/r/30721/diff/1/?file=852101#file852101line145>
> >
> >     we can directly have return statement here "return true"

Will modify the test


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30721/#review73527
-----------------------------------------------------------


On Feb. 6, 2015, 9:27 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30721/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 9:27 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1017 and FALCON-556
>     https://issues.apache.org/jira/browse/FALCON-1017
>     https://issues.apache.org/jira/browse/FALCON-556
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Modifying FeedReplicationTest to check for _SUCCESS availability on target directory
as per FALCON-556
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
64574a5 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
b88cffc 
> 
> Diff: https://reviews.apache.org/r/30721/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message