falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 31149: Add test to support current & last week el expression
Date Thu, 19 Feb 2015 17:34:07 GMT


> On Feb. 19, 2015, 3:50 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java,
lines 181-197
> > <https://reviews.apache.org/r/31149/diff/1/?file=867257#file867257line181>
> >
> >     TimeUtil.getMinuteDatesOnEitherSide(String startOozieDate, String endOozieDate,
int minuteSkip, DateTimeFormatter formatter) should be used with SimpleDateFormat("yyyy/MM/dd/HH/mm")

This approach look way better. Thanks.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/#review73150
-----------------------------------------------------------


On Feb. 18, 2015, 3:41 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31149/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:41 a.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-843
>     https://issues.apache.org/jira/browse/FALCON-843
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31149/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message