falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Re: Review Request 31149: Add test to support current & last week el expression
Date Thu, 19 Feb 2015 15:50:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/#review73150
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119372>

    we should import only classes that are used



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119376>

    not used



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119374>

    can be local in @BeforeMethod



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119373>

    we can just use bundles[0].getProcessName() once again here without creating another String



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119375>

    there is no reason to create empty list here



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119377>

    TimeUtil.getMinuteDatesOnEitherSide(String startOozieDate, String endOozieDate, int minuteSkip,
DateTimeFormatter formatter) should be used with SimpleDateFormat("yyyy/MM/dd/HH/mm")


- Ruslan Ostafiychuk


On Feb. 18, 2015, 3:41 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31149/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:41 a.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-843
>     https://issues.apache.org/jira/browse/FALCON-843
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31149/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message