falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha GS" <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 30116: Parallel update APIs create 2 coords
Date Mon, 16 Feb 2015 07:26:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30116/#review72579
-----------------------------------------------------------

Ship it!


Minor comments. Looks good otherwise


prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment118635>

    entity.toShortString() already contain entity name



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment118640>

    e.toShortString() already contain name



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment118641>

    Use shortString()


- Shwetha GS


On Feb. 13, 2015, 1:54 p.m., Suhas  Vasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30116/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 1:54 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In distributed mode, when parallel update command are issued for same entity, they are
not syncronized.
> This leads to multiple coordinators being spawned in Oozie.
> 
> We need to ensure that the update method is syncronized.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java PRE-CREATION 
>   common/src/test/java/org/apache/falcon/entity/lock/MemoryLocksTest.java PRE-CREATION

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0d34ef3 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
b8d12ee 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 118003f 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 40f8e04

> 
> Diff: https://reviews.apache.org/r/30116/diff/
> 
> 
> Testing
> -------
> 
> UT's were added and were successful
> 
> 
> Thanks,
> 
> Suhas  Vasu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message