falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha GS" <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 30116: Parallel update APIs create 2 coords
Date Tue, 03 Feb 2015 10:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30116/#review70728
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java
<https://reviews.apache.org/r/30116/#comment116099>

    Use some small data like Bool(so that memory used is less) as this is constant and not
used anywhere



common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java
<https://reviews.apache.org/r/30116/#comment116100>

    you can instantiate this at 'private static MemoryLocks instance' to avoid getInstance()
synchronised



common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java
<https://reviews.apache.org/r/30116/#comment116102>

    this should be synchronised so that 2 threads will not get the same lock



common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java
<https://reviews.apache.org/r/30116/#comment116108>

    Add UTs for Memory Locks



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment116103>

    static?



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment116104>

    tokenList can never be empty?



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment116109>

    acquireLock() doesn't throw exception?



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment116110>

    we should get just entity lock(not dependents) at schedule() as well



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
<https://reviews.apache.org/r/30116/#comment116111>

    Update API actually takes longer because of dryRun that you should be able to add IT.
Can you check please?


- Shwetha GS


On Feb. 2, 2015, 12:51 p.m., Suhas  Vasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30116/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 12:51 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In distributed mode, when parallel update command are issued for same entity, they are
not syncronized.
> This leads to multiple coordinators being spawned in Oozie.
> 
> We need to ensure that the update method is syncronized.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java PRE-CREATION 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0d34ef3 
> 
> Diff: https://reviews.apache.org/r/30116/diff/
> 
> 
> Testing
> -------
> 
> UT's were added and were successful
> 
> 
> Thanks,
> 
> Suhas  Vasu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message