falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FALCON-1003) Update checkstyle to remove DoubleCheckedLocking
Date Wed, 21 Jan 2015 10:16:35 GMT

     [ https://issues.apache.org/jira/browse/FALCON-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pallavi Rao updated FALCON-1003:
--------------------------------
    Attachment: FALCON-1003-v2.patch

Based on comment from [~samarthg], upgraded the plugin version to the latest. But, there were
some breakages. So, had to add suppressions to ignore generated sources and surefire reports.
Had to modify some properties files to add newline. 

Also, I'm not sure how to tell checkstyle to check for a /**... header for java files and
#... header for .properties files. So, have restricted the checkstyle to check header only
for Java files right now.


> Update checkstyle to remove DoubleCheckedLocking
> ------------------------------------------------
>
>                 Key: FALCON-1003
>                 URL: https://issues.apache.org/jira/browse/FALCON-1003
>             Project: Falcon
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Pallavi Rao
>            Assignee: Pallavi Rao
>            Priority: Trivial
>         Attachments: FALCON-1003-v2.patch, FALCON-1003.patch
>
>
> As per, http://checkstyle.sourceforge.net/releasenotes.html, Release 5.6 onwards - "Removed
the DoubleCheckedLocking check, as in Java 5 (and beyond), using the volatile keyword addresses
the issue. See here for more details."
> Primary reason for removing this is, I couldn't load the existing checkstyle file in
my IntelliJ checkstyle plugin because DoubleCheckedLocking check was enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message