falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 19094: Add touch option to force update an entity
Date Sun, 11 Jan 2015 01:09:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19094/#review67594
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19094/#comment111638>

    Perhaps we can add an optional switch -force valid only on entity -update command instead
of adding a new one.



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19094/#comment111639>

    If we do use entity -update -force option, then bunch of these changes can be removed.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19094/#comment111640>

    updateInternal being tucked inside stringbuilder::append makes it extremely hard from
a readability stand point. Would prefer that it is in an independent statement. Again if this
implemented with a force switch within update, this additional method & interface extension
can be avoided.


- Srikanth Sundarrajan


On Jan. 6, 2015, 8:41 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19094/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 8:41 a.m.)
> 
> 
> Review request for Falcon and shwethags.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add touch option to force update an entity in workflow engine(even without any changes
to entity)
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java ca514c1 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 7f1bc27 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
f5b142b 
>   docs/src/site/twiki/FalconCLI.twiki d37cf8c 
>   docs/src/site/twiki/restapi/EntityTouch.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java f1f96b1

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 4a686e7 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
a4d1f8b 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
cfa70a0 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 2ec7f66

>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 118003f 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 40f8e04

> 
> Diff: https://reviews.apache.org/r/19094/diff/
> 
> 
> Testing
> -------
> 
> Unit testing and end to end testing done
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message