falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "shaik idris" <psychid...@gmail.com>
Subject Re: Review Request 29522: falcon feed replication should honour availability flag
Date Tue, 06 Jan 2015 12:20:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29522/#review66820
-----------------------------------------------------------



replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java
<https://reviews.apache.org/r/29522/#comment110462>

    Minor, can you prefix the property name with falcon.
    falcon.feed.availability.flag



replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java
<https://reviews.apache.org/r/29522/#comment110463>

    Since it is used multiple times as String, make sense to extract feed.availability.flag
as constant.


- shaik idris


On Jan. 6, 2015, 10:50 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29522/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 10:50 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-237
>     https://issues.apache.org/jira/browse/FALCON-237
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> falcon feed replication should honour availability flag
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java
2963ac9 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java
cbe055a 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
75faceb 
>   oozie/src/main/resources/action/feed/replication-action.xml da40b74 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java
e5588b4 
>   replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java 90ac753

>   replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java 58c09b4

> 
> Diff: https://reviews.apache.org/r/29522/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message