Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ACE19C195 for ; Wed, 10 Dec 2014 09:03:25 +0000 (UTC) Received: (qmail 53117 invoked by uid 500); 10 Dec 2014 09:03:25 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 53079 invoked by uid 500); 10 Dec 2014 09:03:25 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 53068 invoked by uid 99); 10 Dec 2014 09:03:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 09:03:24 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Dec 2014 09:03:01 +0000 Received: (qmail 52807 invoked by uid 99); 10 Dec 2014 09:02:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 09:02:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F4561D2108; Wed, 10 Dec 2014 09:02:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8403752364205993039==" MIME-Version: 1.0 Subject: Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API to use Hive Metastore API From: "Suhas Vasu" To: shwetha.gs@inmobi.com, "Suhas Vasu" , "Falcon" Date: Wed, 10 Dec 2014 09:02:56 -0000 Message-ID: <20141210090256.5765.47591@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suhas Vasu" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/28740/ X-Sender: "Suhas Vasu" References: <20141209161148.5766.97536@reviews.apache.org> In-Reply-To: <20141209161148.5766.97536@reviews.apache.org> Reply-To: "Suhas Vasu" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============8403752364205993039== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 9, 2014, 4:11 p.m., Suhas Vasu wrote: > > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140 > > > > > > Should we be using HiveMetastoreClient for tests as well to maintain consistency ? > > shwethags wrote: > I wasn't able to get create table working with hive metastore client. So, left the tests as is > > Suhas Vasu wrote: > if there are differences between the HiveMetastoreClient and Hcat api in the later versions, we might not catch them effectively. Apart from that its a +1 from me > > shwethags wrote: > HCatClient is just a wrapper around HiveMetastoreClient and hive metastore is the source of truth. So, it should be ok If thats the case, it should be fine - Suhas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28740/#review64381 ----------------------------------------------------------- On Dec. 9, 2014, 11:53 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28740/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 11:53 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-419 > https://issues.apache.org/jira/browse/FALCON-419 > > > Repository: falcon-git > > > Description > ------- > > changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient. > > > Diffs > ----- > > common/pom.xml 50dd2ea > common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0 > common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705 > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a > pom.xml 7a8aacc > prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29 > rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0 > webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96 > webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b > webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4 > webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08 > > Diff: https://reviews.apache.org/r/28740/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > > --===============8403752364205993039==--