Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8910106474811475973=="
MIME-Version: 1.0
Subject: Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
 to use Hive Metastore API
From: "Suhas  Vasu" <suhas.ysr@gmail.com>
To: shwetha.gs@inmobi.com, "Suhas  Vasu" <suhas.ysr@gmail.com>,
 "Falcon" <dev@falcon.incubator.apache.org>
Date: Tue, 09 Dec 2014 19:23:35 -0000
Message-ID: <20141209192335.5766.32151@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Suhas  Vasu" <noreply@reviews.apache.org>
References: <20141209161148.5766.97536@reviews.apache.org>
In-Reply-To: <20141209161148.5766.97536@reviews.apache.org>
Reply-To: "Suhas  Vasu" <suhas.ysr@gmail.com>

--===============8910106474811475973==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 9, 2014, 4:11 p.m., Suhas  Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> >     Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
> 
> shwethags wrote:
>     I wasn't able to get create table working with hive metastore client. So, left the tests as is

if there are differences between the HiveMetastoreClient and Hcat api in the later versions, we might not catch them effectively. Apart from that its a +1 from me


- Suhas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------


On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 11:53 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-419
>     https://issues.apache.org/jira/browse/FALCON-419
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml 50dd2ea 
>   common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0 
>   common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a 
>   pom.xml 7a8aacc 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29 
>   rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0 
>   webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96 
>   webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b 
>   webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4 
>   webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08 
> 
> Diff: https://reviews.apache.org/r/28740/diff/
> 
> 
> Testing
> -------
> 
> UTs
> 
> 
> Thanks,
> 
> shwethags
> 
>


--===============8910106474811475973==--