Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AE7810EB4 for ; Mon, 1 Dec 2014 15:13:44 +0000 (UTC) Received: (qmail 98969 invoked by uid 500); 1 Dec 2014 15:13:43 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 98929 invoked by uid 500); 1 Dec 2014 15:13:43 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 98916 invoked by uid 99); 1 Dec 2014 15:13:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 15:13:43 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 01 Dec 2014 15:13:42 +0000 Received: (qmail 98832 invoked by uid 99); 1 Dec 2014 15:13:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 15:13:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19ED11FB859; Mon, 1 Dec 2014 15:13:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7918594841982475215==" MIME-Version: 1.0 Subject: Re: Review Request 25336: [Falcon-671] Add a test in falcon-regression where one oozie workflow has various actions like mr, hive, pig From: "Paul Isaychuk" To: "Karishma Gulati" , "Paul Isaychuk" , "Falcon" Date: Mon, 01 Dec 2014 15:13:20 -0000 Message-ID: <20141201151320.29132.4706@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Paul Isaychuk" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/25336/ X-Sender: "Paul Isaychuk" References: <20141103130552.10455.76530@reviews.apache.org> In-Reply-To: <20141103130552.10455.76530@reviews.apache.org> Reply-To: "Paul Isaychuk" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============7918594841982475215== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25336/#review63366 ----------------------------------------------------------- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java here is checkstyle issue. Line 61 is longer then 120 symbols. - Paul Isaychuk On Nov. 3, 2014, 1:05 p.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25336/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 1:05 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests. > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java b9acc3b > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java d240e76 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java 86d4d47 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/25336/diff/ > > > Testing > ------- > > > Thanks, > > Karishma Gulati > > --===============7918594841982475215==--