falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suhas Vasu" <suhas....@gmail.com>
Subject Re: Review Request 29092: FALCON-943 process update copying user lib is very slow
Date Thu, 18 Dec 2014 09:40:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29092/#review65475
-----------------------------------------------------------



common/src/main/resources/startup.properties
<https://reviews.apache.org/r/29092/#comment108661>

    "falcon-oozie-adaptorOEB" ? typo ?



docs/src/site/twiki/FalconDocumentation.twiki
<https://reviews.apache.org/r/29092/#comment108662>

    We first set end time and then schedule new process/feed definition.
    I feel we should change this sequence in documentation to avoid confusion to new users.



oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java
<https://reviews.apache.org/r/29092/#comment108665>

    I feel it would be better if we rename jar to jarname or jarfile



oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java
<https://reviews.apache.org/r/29092/#comment108666>

    can we reuse this function above (line 56) ?



oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
<https://reviews.apache.org/r/29092/#comment108669>

    Feel StringUtils.isEmpty would be better


- Suhas  Vasu


On Dec. 16, 2014, 10:42 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29092/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 10:42 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-943
>     https://issues.apache.org/jira/browse/FALCON-943
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Addresses the following:
> 1. Removed copying user workflow/lib to staging directory
> 2. Removed update at specific time
> 3. Copying falcon jars to parent workflow lib copies only specific falcon jars
> 4. Libs copied at cluster submit(3rd party jars) have versions so that its easier to
debug issues
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 93776d3 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 23c8943 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 59e43fb 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java bbe274b 
>   common/src/main/java/org/apache/falcon/entity/ProcessHelper.java 174f8f6 
>   common/src/main/java/org/apache/falcon/update/UpdateHelper.java 5a86ae3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
ae158f7 
>   common/src/main/resources/startup.properties 433c2a8 
>   common/src/test/java/org/apache/falcon/update/UpdateHelperTest.java ef0d769 
>   docs/src/site/twiki/FalconCLI.twiki 202af63 
>   docs/src/site/twiki/FalconDocumentation.twiki 0d2a692 
>   docs/src/site/twiki/restapi/EntityUpdate.twiki f2c2e7e 
>   oozie-el-extensions/src/main/conf/oozie-site.xml PRE-CREATION 
>   oozie-el-extensions/src/test/resources/oozie-site.xml a106aa6 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java c73401a 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java 2ceb91e 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e341fb8 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
771295f 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java 3347fbf 
>   oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java
1db4ca4 
>   oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java
14668f0 
>   oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java
6bd5dd8 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 8691ee5

>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
d271695 
>   oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 9567c5f

>   oozie/src/main/java/org/apache/falcon/workflow/LateDataHandler.java PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 745aaac

>   oozie/src/main/resources/action/post-process.xml 440a131 
>   oozie/src/main/resources/action/pre-process.xml 070c42b 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
3477258 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java b6e1cec 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
fb9d9f3 
>   rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d35abfa 
>   rerun/src/main/java/org/apache/falcon/rerun/handler/LateRerunConsumer.java 9ba632e

>   src/conf/startup.properties 2db4b1e 
>   src/main/assemblies/distributed-package.xml 7320312 
>   src/main/assemblies/standalone-package.xml f9d6009 
>   src/main/examples/data/generate.sh 74ec3ba 
>   webapp/src/main/java/org/apache/falcon/Debug.java c606074 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 98b8b3d 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java a3acbdb 
>   webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java 1885bb7 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f7e6bdb

> 
> Diff: https://reviews.apache.org/r/29092/diff/
> 
> 
> Testing
> -------
> 
> UTs, end to end test for process, retention and replication 
> 
> 
> Thanks,
> 
> shwethags
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message