falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Isaychuk" <pisayc...@hortonworks.com>
Subject Re: Review Request 29059: [FALCON-948] Enabling late rerun tests
Date Mon, 15 Dec 2014 20:02:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/
-----------------------------------------------------------

(Updated Dec. 15, 2014, 8:02 p.m.)


Review request for Falcon.


Bugs: FALCON-948
    https://issues.apache.org/jira/browse/FALCON-948


Repository: falcon-git


Description (updated)
-------

Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols
from data paths, were made to make tests running, as well as some refactoring (replacing method
to HadoopUtil).


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
3cb4f94 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
4f9bd9d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
95919ee 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
da38085 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
e1a4dd4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
488cf74 

Diff: https://reviews.apache.org/r/29059/diff/


Testing
-------

ProcessLateRerunTest was tested locally, passed all times. FeedLateRerunTest fails on rerun
validation.
As for me the reason can be an invalid test case. Because I don't see any references in doc
to have replication reran after late arrival http://falcon.incubator.apache.org/EntitySpecification.html#Feed_Specification.
For me it seems that only process which depends on feed, can be reran that way.
Anyway according to the requirement, we can enable these tests, open a bug for failing test
class and then figure out necessary details.


Thanks,

Paul Isaychuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message