falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samar kumar" <samar.opensou...@gmail.com>
Subject Re: Review Request 28508: Falcon client methods should return objects
Date Thu, 11 Dec 2014 12:58:08 GMT


> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 357
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line357>
> >
> >     should return entity?
> 
> samar kumar wrote:
>     Defination entity is string itself 
>     
>     return clientResponse.getEntity(String.class);
> 
> shwethags wrote:
>     We can unmarshal from String and return Entity?

Done


> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 511
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line511>
> >
> >     Fix these as well? Else, can you create a jira  so that we don't lose track
> 
> samar kumar wrote:
>     return clientResponse.getEntity(String.class);

https://issues.apache.org/jira/browse/FALCON-941


- samar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review63221
-----------------------------------------------------------


On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 12:48 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-329
>     https://issues.apache.org/jira/browse/FALCON-329
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Falcon client methods should return objects
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed 
>   webapp/src/main/java/org/apache/falcon/Debug.java a650215 
> 
> Diff: https://reviews.apache.org/r/28508/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> samar kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message