falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API to use Hive Metastore API
Date Wed, 10 Dec 2014 08:53:35 GMT


> On Dec. 9, 2014, 4:11 p.m., Suhas  Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> >     Should we be using HiveMetastoreClient for tests as well to maintain consistency
?
> 
> shwethags wrote:
>     I wasn't able to get create table working with hive metastore client. So, left the
tests as is
> 
> Suhas  Vasu wrote:
>     if there are differences between the HiveMetastoreClient and Hcat api in the later
versions, we might not catch them effectively. Apart from that its a +1 from me

HCatClient is just a wrapper around HiveMetastoreClient and hive metastore is the source of
truth. So, it should be ok


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------


On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 11:53 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-419
>     https://issues.apache.org/jira/browse/FALCON-419
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml 50dd2ea 
>   common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0

>   common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a 
>   pom.xml 7a8aacc 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java
4ceca29 
>   rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0 
>   webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96 
>   webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b 
>   webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4 
>   webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08 
> 
> Diff: https://reviews.apache.org/r/28740/diff/
> 
> 
> Testing
> -------
> 
> UTs
> 
> 
> Thanks,
> 
> shwethags
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message