falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Re: Review Request 25336: [Falcon-671] Add a test in falcon-regression where one oozie workflow has various actions like mr, hive, pig
Date Wed, 03 Dec 2014 12:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63666
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
<https://reviews.apache.org/r/25336/#comment105946>

    level 16 expected by checkstyle, not 12



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
<https://reviews.apache.org/r/25336/#comment105945>

    we are trying to aviod using runRemoteScriptAsSudo()
    this code will not work on Windows
    
    Looks like this can be done manually with single 'ssh-copy-id' command


- Ruslan Ostafiychuk


On Dec. 3, 2014, 11:06 a.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 11:06 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> A test needs to be added where one worflow has various possible actions like mr, hive,
pig. So far, we just specify the engine type as hive or pig for such specific tests. 
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java
7ead733 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java
82c8919 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java
d878ecb 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java
ed29d07 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION

>   falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/25336/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message