Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0701B10D87 for ; Thu, 27 Nov 2014 14:08:06 +0000 (UTC) Received: (qmail 10406 invoked by uid 500); 27 Nov 2014 14:08:05 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 10364 invoked by uid 500); 27 Nov 2014 14:08:05 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 10353 invoked by uid 99); 27 Nov 2014 14:08:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Nov 2014 14:08:05 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 27 Nov 2014 14:08:03 +0000 Received: (qmail 9362 invoked by uid 99); 27 Nov 2014 14:07:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Nov 2014 14:07:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 019911FB7C8; Thu, 27 Nov 2014 14:07:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0168561254431076628==" MIME-Version: 1.0 Subject: Re: Review Request 25388: Fix problems found by checkstyle in falcon-regression From: "Ruslan Ostafiychuk" To: "Ruslan Ostafiychuk" , "Falcon" Date: Thu, 27 Nov 2014 14:07:41 -0000 Message-ID: <20141127140741.15977.87772@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ruslan Ostafiychuk" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/25388/ X-Sender: "Ruslan Ostafiychuk" References: <20140908133139.23929.19960@reviews.apache.org> In-Reply-To: <20140908133139.23929.19960@reviews.apache.org> Reply-To: "Ruslan Ostafiychuk" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============0168561254431076628== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25388/ ----------------------------------------------------------- (Updated Nov. 27, 2014, 2:07 p.m.) Review request for Falcon. Bugs: FALCON-684 https://issues.apache.org/jira/browse/FALCON-684 Repository: falcon-git Description ------- There are some problems in falcon-regression that can be found by checkstyle. Diffs (updated) ----- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java b3f4b3c falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 5535e00 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/LineageHelper.java 88ea42e falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 02b7529 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 10465b5 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java ee98e51 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 21d897c falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphEntity.java d35ced6 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphResult.java d4be61d falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java acd7be8 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java c5172eb falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 11758ff falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java ee0c072 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6e99f4d falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java 1a97e1d falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java 9d75591 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ba9c419 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java dd9fe5c falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/LogUtil.java ae157ad falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 7c6c73d falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java c6217c1 falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 97c6c75 falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java cf95107 falcon-regression/merlin-core/src/main/java/org/apache/falcon/security/FalconAuthorizationToken.java fa2caf9 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 91d8e67 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseUITestClass.java aab3415 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntitiesPage.java 4dbe070 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntityPage.java 3b2d5d1 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/Page.java d6b55d4 falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/ProcessPage.java 9dd5be2 falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java e3af96d falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 2fa7740 falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 143789f falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 164caa5 falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java 88c26d5 Diff: https://reviews.apache.org/r/25388/diff/ Testing ------- LineageApiTest, LineageApiProcessInstanceTest, PrismFeedUpdateTest Thanks, Ruslan Ostafiychuk --===============0168561254431076628==--