Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3594063543746543138=="
MIME-Version: 1.0
Subject: Re: Review Request 27029: FALCON-697 - Messaging improvements on
 Producer
From: shwetha.gs@inmobi.com
To: shwetha.gs@inmobi.com, "Srikanth Sundarrajan" <sriksun@hotmail.com>,
 "Ajay Yadava" <ajaynsit@gmail.com>
Cc: "Suma Shivaprasad" <sumasai.shivaprasad@gmail.com>,
 "Falcon" <dev@falcon.incubator.apache.org>
Date: Tue, 11 Nov 2014 07:20:39 -0000
Message-ID: <20141111072039.19819.14623@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: noreply@reviews.apache.org
References: <20141110145415.19818.3895@reviews.apache.org>
In-Reply-To: <20141110145415.19818.3895@reviews.apache.org>
Reply-To: shwetha.gs@inmobi.com

--===============3594063543746543138==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27029/#review60762
-----------------------------------------------------------


messaging/src/main/java/org/apache/falcon/messaging/FalconJMSMessageProducer.java
<https://reviews.apache.org/r/27029/#comment102170>

    System message on falcon topic has 1 message. So, feedNames is list of output feed names and feedPaths is list of corresponding output paths. This breaks for retention as feedNames will contain just 1 name and feedPaths will contain list of paths. We need to take care of this


messaging/src/main/java/org/apache/falcon/messaging/FalconJMSMessageProducer.java
<https://reviews.apache.org/r/27029/#comment102171>

    Also, at retention we delete even stats and meta paths of the feed(in addition to data paths) and all these paths are returned in feedPaths. The message should contain just the data paths. We can handle it in another jira as well


messaging/src/main/java/org/apache/falcon/messaging/JMSMessageProducer.java
<https://reviews.apache.org/r/27029/#comment102167>

    Move getBrokerImplClass () and getBrokerUrl () to concrete class?


messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java
<https://reviews.apache.org/r/27029/#comment102169>

    The function shouldn't take feedNames as argument(If there are multiple outputs for the same feed). Isn't feedNamesVsPaths.keySet() enough?


- shwethags


On Nov. 10, 2014, 2:54 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27029/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 2:54 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, shwethags, and Srikanth Sundarrajan.
> 
> 
> Bugs: FALCON-697
>     https://issues.apache.org/jira/browse/FALCON-697
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In case of EVICTION and REPLICATION, generating one message per feed to both FALCON topic and user topic with all feed paths
> 
> In case of GENERATE, in system topic(FALCON.ENITITY.TOPIC) generating one message per process with all the feed paths. In User topic(FALCON Feedname/process), generating one message per feed for feed name topics and one message per process topic with all the feed paths
> 
> 
> Diffs
> -----
> 
>   messaging/src/main/java/org/apache/falcon/messaging/FalconJMSMessageProducer.java PRE-CREATION 
>   messaging/src/main/java/org/apache/falcon/messaging/JMSMessageProducer.java 629e6a5 
>   messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java PRE-CREATION 
>   messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java 2f5aa70 
>   messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java d4373de 
>   messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 1cd3310 
> 
> Diff: https://reviews.apache.org/r/27029/diff/
> 
> 
> Testing
> -------
> 
> Made UT changes to current tests
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


--===============3594063543746543138==--