Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9209A17487 for ; Tue, 11 Nov 2014 02:11:14 +0000 (UTC) Received: (qmail 15541 invoked by uid 500); 11 Nov 2014 02:11:14 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 15495 invoked by uid 500); 11 Nov 2014 02:11:14 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 15468 invoked by uid 99); 11 Nov 2014 02:11:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 02:11:14 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Nov 2014 02:10:50 +0000 Received: (qmail 15285 invoked by uid 99); 11 Nov 2014 02:10:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 02:10:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 560511DFD7A; Tue, 11 Nov 2014 02:10:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2327708783447691725==" MIME-Version: 1.0 Subject: Re: Review Request 27029: FALCON-697 - Messaging improvements on Producer From: "Ajay Yadava" To: shwetha.gs@inmobi.com, "Srikanth Sundarrajan" , "Ajay Yadava" Cc: "Suma Shivaprasad" , "Falcon" Date: Tue, 11 Nov 2014 02:10:51 -0000 Message-ID: <20141111021051.19819.13924@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/27029/ X-Sender: "Ajay Yadava" References: <20141110145415.19818.3895@reviews.apache.org> In-Reply-To: <20141110145415.19818.3895@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============2327708783447691725== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27029/#review60729 ----------------------------------------------------------- messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java Documenting an example of how a message for feed/process looks like will help readers to understand what's going on. messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java It is probably better for the function to return a map instead of receiving one and modifying it as it will reduce coupling between the two methods and improve testability. messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java I think these lines can be removed. messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java Use logger. messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java Use Logger please. - Ajay Yadava On Nov. 10, 2014, 2:54 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27029/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 2:54 p.m.) > > > Review request for Falcon, Ajay Yadava, shwethags, and Srikanth Sundarrajan. > > > Bugs: FALCON-697 > https://issues.apache.org/jira/browse/FALCON-697 > > > Repository: falcon-git > > > Description > ------- > > In case of EVICTION and REPLICATION, generating one message per feed to both FALCON topic and user topic with all feed paths > > In case of GENERATE, in system topic(FALCON.ENITITY.TOPIC) generating one message per process with all the feed paths. In User topic(FALCON Feedname/process), generating one message per feed for feed name topics and one message per process topic with all the feed paths > > > Diffs > ----- > > messaging/src/main/java/org/apache/falcon/messaging/FalconJMSMessageProducer.java PRE-CREATION > messaging/src/main/java/org/apache/falcon/messaging/JMSMessageProducer.java 629e6a5 > messaging/src/main/java/org/apache/falcon/messaging/UserJMSMessageProducer.java PRE-CREATION > messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java 2f5aa70 > messaging/src/test/java/org/apache/falcon/messaging/JMSMessageProducerTest.java d4373de > messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 1cd3310 > > Diff: https://reviews.apache.org/r/27029/diff/ > > > Testing > ------- > > Made UT changes to current tests > > > Thanks, > > Suma Shivaprasad > > --===============2327708783447691725==--