falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-877) Pagination API should have a cap on number of results returned
Date Fri, 28 Nov 2014 03:04:12 GMT

    [ https://issues.apache.org/jira/browse/FALCON-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228058#comment-14228058
] 

Srikanth Sundarrajan commented on FALCON-877:
---------------------------------------------

{code}
+    protected static final int MAX_RESULTS = Integer.valueOf(RuntimeProperties.get()
+            .getProperty("webservices.default.max.results.per.page", "100"));
{code}
Should there be a typo or an incorrect value for the property, it would end up with a runtime
exception resulting in class loading failure. This might in turn cause HTTP:404 totally misleading
the user triaging the issue. 

This has to fall back to sane default with a WARN should there be an incorrect value, particularly
given that this is in static section of the class.

> Pagination API should have a cap on number of results returned
> --------------------------------------------------------------
>
>                 Key: FALCON-877
>                 URL: https://issues.apache.org/jira/browse/FALCON-877
>             Project: Falcon
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Ajay Yadav
>            Assignee: Ajay Yadav
>         Attachments: FALCON-877-v1.patch, FALCON-877.patch
>
>
> Currently one can specify any arbitrary large number for number of results and falcon
will return "all" or the specified number of results (whichever is smaller). This defeats
the purpose of pagination as users can still ask for all the results in one go. There should
be an upper bound on number of results to be returned by client/service calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message