falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-864) Falcon superuser is unable to delete scheduled feed
Date Thu, 06 Nov 2014 10:39:33 GMT

    [ https://issues.apache.org/jira/browse/FALCON-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200059#comment-14200059

Srikanth Sundarrajan commented on FALCON-864:

This can be misleading
+        } catch (FalconException e) {
+            throw new EntityNotRegisteredException(e.getMessage());

Would like the method to indicate that it is attempting to proxy and falls back to the login
user if the user isn't super-user. Can the CurrentUser have a method for canProxy() and then
tryProxy consult it before attempting to proxy, in which case proxy can be strict about its
attempt to proxy, canProxy can be a trivial check to see if the user is a super user.
+                tryProxy(requestParts.getEntityType(), requestParts.getEntityName());
+    public static void proxy(final String proxyUser) throws IOException {

Would really like audit trace when super user is proxying an user.

Some empty lines with just closing paranthesis and semi colon are found in the patch. You
might want to pull it up into the earlier line if it doesn't violate the length check as per
our checkstyle rule.

> Falcon superuser is unable to delete scheduled feed
> ---------------------------------------------------
>                 Key: FALCON-864
>                 URL: https://issues.apache.org/jira/browse/FALCON-864
>             Project: Falcon
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Blocker
>             Fix For: 0.6
>         Attachments: FALCON-864.patch
> Falcon superuser when tries to delete a scheduled entity is unable to do so.
> Problematic operations:delete, update, suspend, resume

This message was sent by Atlassian JIRA

View raw message