falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-807) Fix order of actual and expected expression in assert statements.
Date Wed, 19 Nov 2014 02:57:34 GMT

    [ https://issues.apache.org/jira/browse/FALCON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217322#comment-14217322
] 

Srikanth Sundarrajan commented on FALCON-807:
---------------------------------------------

Changes looks good. Can you confirm if this fix is comprehensive in its coverage across all
assertions?

> Fix order of actual and expected expression in assert statements.
> -----------------------------------------------------------------
>
>                 Key: FALCON-807
>                 URL: https://issues.apache.org/jira/browse/FALCON-807
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Ajay Yadav
>            Assignee: Ajay Yadav
>         Attachments: FALCON-807.patch
>
>
> In Assert statements like assertEquals, actual expression should be first and expected
expression should be second argument. In certain files e.g. FalconCLIIT.java we have it other
way round. 
> Impact of this is:
> When the test fails the error message will say something like:
> Expected -1 but was 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message