falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-593) Preserve data type for properties in a vertex
Date Fri, 28 Nov 2014 03:11:12 GMT

    [ https://issues.apache.org/jira/browse/FALCON-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228061#comment-14228061
] 

Srikanth Sundarrajan commented on FALCON-593:
---------------------------------------------

{code}
...
+    protected Vertex addVertex(String name, RelationshipType type, Long timestamp) {
...
+    protected Vertex createVertex(String name, RelationshipType type, Long timestamp) {
...
+    public Date getTimeStampAsDate() {
...
+        } catch (java.text.ParseException e) {
...
{code}

* Should timestamp parameter be simply a primitive long instead of an object ?
* Seems like Timestamp returned as date is always converted to timeInMillis from epoch, should
the function directly return that?
* Can new Date().getTime() be replaced with System.currentTimeInMillis() ?
* Can ParseException be imported?

> Preserve data type for properties in a vertex 
> ----------------------------------------------
>
>                 Key: FALCON-593
>                 URL: https://issues.apache.org/jira/browse/FALCON-593
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Ajay Yadav
>         Attachments: FALCON-593.patch
>
>
> Timestamps are converted to string and stored as a property in a vertex. We could preserve
the types and could use these in queries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message