falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-145) Feed eviction be implemented in appropriate Storage implementation
Date Mon, 03 Nov 2014 10:45:34 GMT

    [ https://issues.apache.org/jira/browse/FALCON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194424#comment-14194424
] 

Srikanth Sundarrajan commented on FALCON-145:
---------------------------------------------

I would suggest that we leave the methods in EvictionInstancesSerDe as is and add EvictionHelper,
but ensure that there are no code repetition.

> Feed eviction be implemented in appropriate Storage implementation
> ------------------------------------------------------------------
>
>                 Key: FALCON-145
>                 URL: https://issues.apache.org/jira/browse/FALCON-145
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Venkatesh Seetharam
>            Assignee: Srikanth Sundarrajan
>         Attachments: FALCON-145-v2.patch, FALCON-145-v3.patch, FALCON-145-v4.patch, falcon-145.patch
>
>
> Since the feed storage is abstracted in Storage class either as FileSystemStorage or
CatalogStorage, moreover, behaviors for listing partitions and drop partitions are listed
there, why do we need to hardcode the eviction behavior and instance deletion discovery for
filesystem need to happen in FeedEvictor ? Why can't be implemented in appropriate Storage
implementation. That way FeedEvictor would simpler and lot cleaner. 
> This can apply to table replication as well for import and export of partitions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message