falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Review Request 28525: Fix checkstyle bugs in test files in falcon-regression
Date Fri, 28 Nov 2014 12:06:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28525/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-698
    https://issues.apache.org/jira/browse/FALCON-698


Repository: falcon-git


Description
-------

There are a lot of problems in falcon-regression that can be found by checkstyle.


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
02f572e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
d81f577 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java
f090356 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java
PRE-CREATION 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
f4f97b6 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpFutureAndLatestTest.java
PRE-CREATION 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java
25e2dfe 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java
7555c0c 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java
a5e7ff8 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java
637f8a2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java
229dccd 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java
15659d2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
ced5fbf 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
0c160ea 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java
1c8b176 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java
5df9d05 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java
77b82ae 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java 670f6db

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
871e8dc 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java
7a232ba 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java
7d7179c 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
5bbba8f 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
3f7258e 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java
c2d8c9b 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java
9de179b 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java
51c38cc 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java
f01f30e 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
66372e9 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
fce0bf5 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
db40931 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
4ba3cd3 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java
8213cd9 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java
6e02822 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
6d29f77 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
c964210 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java
991732b 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java
a0cd014 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java
5c04e20 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismClusterDeleteTest.java
c601345 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismConcurrentRequestTest.java
c767649 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java
3bbeca1 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java
1cc558e 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
ed2d9d7 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java
63011b8 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedResumeTest.java
79ceacc 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedScheduleTest.java
9a32932 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java
b8f3095 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSuspendTest.java
7de5e39 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
9b5d770 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java
05b5276 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessResumeTest.java
c2b9681 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
ce6f675 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java
a83b8f4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSuspendTest.java
4347040 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java
b11d586 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java
1a3f82f 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java
dac4cf6 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java
e1cdab4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
3d471f6 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
a61b400 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java
6e1855b 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java
cc6da00 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java
5ea6266 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
a716e56 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java
46019fa 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java
2a623e6 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java
5cbe321 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java
9282d2c 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/Configuration.java
1ab0140 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/Configuration.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/DateValidator.java
f02ed34 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/DateValidator.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/TimeUnit.java
67f9d4c 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/2ndLateData/TimeUnit.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessage.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessage.java.ignore.java
f992f21 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessageCreator.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/EntityInstanceMessageCreator.java.ignore.java
f7e8bbb 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/MessageProducer.java.ignore
PRE-CREATION 
  falcon-regression/merlin/src/test/resources/OozieExampleInputData/normalInput/MessageProducer.java.ignore.java
7234f52 

Diff: https://reviews.apache.org/r/28525/diff/


Testing
-------

renamed normal input was tested with NoOutputTest and ProcessLibPathTest


Thanks,

Ruslan Ostafiychuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message