falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samar kumar" <samar.opensou...@gmail.com>
Subject Re: Review Request 25384: Falcon Desinger Data Model and JAVA Apis design
Date Tue, 18 Nov 2014 14:15:16 GMT


> On Nov. 4, 2014, 8:46 a.m., Srikanth Sundarrajan wrote:
> > addons/designer/pom.xml, line 409
> > <https://reviews.apache.org/r/25384/diff/1/?file=680382#file680382line409>
> >
> >     Looks like there is a implicit assumption that this will work only for hadoop-2?
Is that right? If we are making that assumption, it is better to discuss that independently,
as that is a major decision.
> 
> samar kumar wrote:
>     yes I have made that assumption. Will push a mail on the mailing list to discuss
further

As per the mailing list response. We would only support 2.x.x


> On Nov. 4, 2014, 8:46 a.m., Srikanth Sundarrajan wrote:
> > addons/designer/core/src/main/java/org/apache/falcon/designer/core/service/FalconDesigner.java,
line 97
> > <https://reviews.apache.org/r/25384/diff/2/?file=683576#file683576line97>
> >
> >     Deleting a specific version seems very distrubing to me.

Would need further discussion on this?


> On Nov. 4, 2014, 8:46 a.m., Srikanth Sundarrajan wrote:
> > addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/builder/FlowBuilder.java,
line 33
> > <https://reviews.apache.org/r/25384/diff/2/?file=683573#file683573line33>
> >
> >     Consider using lombok. Check APL 2.0 compatibility before introducing

Under MIT license.Can that be taken in a seperate jira, which we can just have the model here?


- samar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25384/#review52466
-----------------------------------------------------------


On Nov. 12, 2014, 3:06 p.m., samar kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25384/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 3:06 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-672
>     https://issues.apache.org/jira/browse/FALCON-672
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Contails Falcon Desinger Data Model and JAVA Apis design for the server/client
> 
> 
> Diffs
> -----
> 
>   addons/designer/actions/pom.xml 7d5afbb 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/EmailActionConfiguration.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/TransformationActionConfiguration.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/primitive/EmailAction.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/primitive/builder/TransformationActionConfigurationBuilder.java
PRE-CREATION 
>   addons/designer/core/pom.xml ddd8814 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/Configuration.java
dba908a 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/ActionConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/Configuration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/Feed.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/FlowConfig.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/SerdeException.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/configuration/TransformConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Action.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Code.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/CompilationException.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Flow.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Message.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Primitive.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/Transform.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/builder/BuilderException.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/primitive/builder/FlowBuilder.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/schema/RelationalData.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/schema/RelationalSchema.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/service/FalconDesigner.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/service/impl/FalconDesignerImpl.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/source/DataSource.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/Storage.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/StorageException.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/Storeable.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/Version.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/VersionedStorage.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/storage/impl/HDFSStorage.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/core/sysconfig/SystemConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Action.java
c40e462 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Code.java 35eeeb1

>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/CompilationException.java
603225b 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Message.java
e5a68a8 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java
aa2b988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Transform.java
72cf988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/schema/RelationalData.java
d930e40 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/schema/RelationalSchema.java
f4f44d1 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/source/DataSource.java
227277c 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/Storage.java
5b63b31 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/StorageException.java
c8c2f58 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/Storeable.java
384d17a 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/Version.java
35c2e86 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/VersionedStorage.java
7f5edc5 
>   addons/designer/core/src/test/java/org/apache/falcon/designer/core/storage/impl/HDFSStorageTest.java
PRE-CREATION 
>   addons/designer/examples/pom.xml PRE-CREATION 
>   addons/designer/examples/src/main/java/org/apache/falcon/designer/examples/flow/SimpleFlowExample.java
PRE-CREATION 
>   addons/designer/flows/pom.xml ce706a3 
>   addons/designer/pom.xml 3e1a98a 
>   addons/designer/server/pom.xml PRE-CREATION 
>   addons/designer/server/src/main/java/org/apache/falcon/designer/server/service/FalconDesignerResource.java
PRE-CREATION 
>   addons/designer/server/src/main/java/org/apache/falcon/designer/server/service/client/DesignerFlowRestClient.java
PRE-CREATION 
>   addons/designer/server/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   addons/designer/transforms/pom.xml 6f55129 
>   addons/designer/transforms/src/main/java/org/apache/falcon/designer/transformation/configuration/CoGroupTransformation.java
PRE-CREATION 
>   addons/designer/transforms/src/main/java/org/apache/falcon/designer/transformation/configuration/FilterTransformation.java
PRE-CREATION 
>   addons/designer/transforms/src/main/java/org/apache/falcon/designer/transformation/configuration/GroupByTransformation.java
PRE-CREATION 
>   addons/designer/transforms/src/main/java/org/apache/falcon/designer/transformation/configuration/JoinTransformation.java
PRE-CREATION 
>   addons/designer/transforms/src/main/java/org/apache/falcon/designer/transformation/configuration/ProjectionTransformation.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> samar kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message