falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 28042: [FALCON-895] Fix intermittent failures in ProcessInstanceStatus and Kills test classes.
Date Fri, 14 Nov 2014 19:24:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28042/#review61485
-----------------------------------------------------------

Ship it!


Ship It!

- Raghav Gautam


On Nov. 14, 2014, 9:09 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28042/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 9:09 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-895
>     https://issues.apache.org/jira/browse/FALCON-895
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Changes to make tests more stable. 
> Few comments:
> ProcessInstance.testProcessInstanceKillKillNonMaterialized changed to testProcessInstanceKillKillNotRunning
because as defined, only RUNNING instances can be killed. Also the argument is that non-materialized
states, like READY, SUBMITTED are generally considered the same as WAITING during instance-oriented
requests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
6c92711 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
7b3fb62 
> 
> Diff: https://reviews.apache.org/r/28042/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message