falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Seetharam Venkatesh" <venkat...@innerzeal.com>
Subject Re: Review Request 27718: FALCON-864 Falcon superuser is unable to delete scheduled feed
Date Fri, 07 Nov 2014 17:09:41 GMT


> On Nov. 7, 2014, 3:45 p.m., Srikanth Sundarrajan wrote:
> > common/src/main/java/org/apache/falcon/security/DefaultAuthorizationProvider.java,
line 342
> > <https://reviews.apache.org/r/27718/diff/1-2/?file=754227#file754227line342>
> >
> >     catch EntityNotRegisteredException and throw instead of catch base exception
and checking again for EntityNotRegisteredException.
> >     
> >     Any reason why you would want to wrap the FalconException with AuthorizationException
?

The problem is for non-existing entities, we need to throw 401 bad request but auth failures
should throw 403. Hence this circus. Will open a jira to decentralize authorization post 0.6.
I thought it could be uniformly enforced but its too much work and resulted in kludges like
these.


- Seetharam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27718/#review60330
-----------------------------------------------------------


On Nov. 7, 2014, 2:09 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27718/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 2:09 a.m.)
> 
> 
> Review request for Falcon and Seetharam Venkatesh.
> 
> 
> Bugs: FALCON-864
>     https://issues.apache.org/jira/browse/FALCON-864
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Falcon superuser is unable to delete scheduled feed
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/cleanup/AbstractCleanupHandler.java be300d7

>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java bcebb94 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 953c19e 
>   common/src/main/java/org/apache/falcon/entity/ProcessHelper.java 8073229 
>   common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5a7ec17

>   common/src/main/java/org/apache/falcon/entity/parser/EntityParser.java e2742a1 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java a724695

>   common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java aaaa229

>   common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java 1496268 
>   common/src/main/java/org/apache/falcon/security/AuthorizationProvider.java 1b36c4e

>   common/src/main/java/org/apache/falcon/security/CurrentUser.java 3d35630 
>   common/src/main/java/org/apache/falcon/security/DefaultAuthorizationProvider.java e7895f8

>   common/src/main/java/org/apache/falcon/security/FalconPrincipal.java ab93e1a 
>   common/src/main/java/org/apache/falcon/update/UpdateHelper.java 7782c71 
>   common/src/test/java/org/apache/falcon/security/CurrentUserTest.java 187d85e 
>   common/src/test/java/org/apache/falcon/security/DefaultAuthorizationProviderTest.java
0a40359 
>   oozie/src/main/java/org/apache/falcon/logging/LogProvider.java 6844f31 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 4108839 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
f7fed45 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java
c578005 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 3e54bd2

>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
24437fc 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieClientFactory.java d598097

>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieHouseKeepingService.java
d9fe8c1 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 89bebe7

>   oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java a7c6960 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 80b2429 
>   prism/src/main/java/org/apache/falcon/security/FalconAuditFilter.java 9a9b400 
>   prism/src/main/java/org/apache/falcon/security/FalconAuthenticationFilter.java fa30f0e

>   prism/src/main/java/org/apache/falcon/security/FalconAuthorizationFilter.java 3cdb749

>   prism/src/test/java/org/apache/falcon/security/FalconAuthorizationFilterTest.java 03dc792

>   rerun/src/main/java/org/apache/falcon/rerun/handler/LateRerunHandler.java 6a8017e 
> 
> Diff: https://reviews.apache.org/r/27718/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message