Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B300517231 for ; Wed, 8 Oct 2014 17:39:53 +0000 (UTC) Received: (qmail 50593 invoked by uid 500); 8 Oct 2014 17:39:52 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 50557 invoked by uid 500); 8 Oct 2014 17:39:52 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 50528 invoked by uid 99); 8 Oct 2014 17:39:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 17:39:52 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 08 Oct 2014 17:39:50 +0000 Received: (qmail 48834 invoked by uid 99); 8 Oct 2014 17:39:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 17:39:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B568D1DDD51; Wed, 8 Oct 2014 17:39:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6382113222018844049==" MIME-Version: 1.0 Subject: Re: Review Request 26110: Add ACL validation and enforcement tests From: "Raghav Gautam" To: "Ruslan Ostafiychuk" , "Raghav Gautam" , "Falcon" Date: Wed, 08 Oct 2014 17:39:26 -0000 Message-ID: <20141008173926.24818.28576@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Raghav Gautam" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/26110/ X-Sender: "Raghav Gautam" References: <20141007111723.24817.88152@reviews.apache.org> In-Reply-To: <20141007111723.24817.88152@reviews.apache.org> Reply-To: "Raghav Gautam" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============6382113222018844049== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 7, 2014, 4:17 a.m., Ruslan Ostafiychuk wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java, lines 68-70 > > > > > > If ArrayUtils.isEmpty() == true then Arrays.deepToString() will return 'null' or '[]'. I think 'arrX can't be empty' is enough. It will help us differentitate between the null and empty array case. - Raghav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26110/#review55643 ----------------------------------------------------------- On Oct. 8, 2014, 10:39 a.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26110/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 10:39 a.m.) > > > Review request for Falcon. > > > Bugs: falcon-746 > https://issues.apache.org/jira/browse/falcon-746 > > > Repository: falcon-git > > > Description > ------- > > Add ACL validation and enforcement tests. > > > Diffs > ----- > > falcon-regression/README.md 659657c > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 33b67f7 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java 025fc15 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java a10dfc1 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java eac3cb4 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 3a56530 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 66a1b7f > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java PRE-CREATION > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java d8ac903 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java bf99291 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 1bbe8d9 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 30eaf61 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/26110/diff/ > > > Testing > ------- > > Adding new tests. > > > Thanks, > > Raghav Gautam > > --===============6382113222018844049==--