Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A7FD217318 for ; Fri, 3 Oct 2014 05:43:55 +0000 (UTC) Received: (qmail 1367 invoked by uid 500); 3 Oct 2014 05:43:55 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 1325 invoked by uid 500); 3 Oct 2014 05:43:55 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 1308 invoked by uid 99); 3 Oct 2014 05:43:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 05:43:55 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 03 Oct 2014 05:43:32 +0000 Received: (qmail 197 invoked by uid 99); 3 Oct 2014 05:43:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 05:43:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 22D8B1DDC1F; Fri, 3 Oct 2014 05:43:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4434442942334184948==" MIME-Version: 1.0 Subject: Re: Review Request 26297: Fixing PrismFeedUpdateTest and FeedInstanceStatus test issues From: "Ruslan Ostafiychuk" To: "Ruslan Ostafiychuk" , "Raghav Gautam" , "Falcon" Date: Fri, 03 Oct 2014 05:43:27 -0000 Message-ID: <20141003054327.19041.83254@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ruslan Ostafiychuk" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/26297/ X-Sender: "Ruslan Ostafiychuk" References: <20141002235954.18846.69560@reviews.apache.org> In-Reply-To: <20141002235954.18846.69560@reviews.apache.org> Reply-To: "Ruslan Ostafiychuk" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============4434442942334184948== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26297/#review55327 ----------------------------------------------------------- Ship it! Ship It! - Ruslan Ostafiychuk On Oct. 2, 2014, 11:59 p.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26297/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 11:59 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Found multiple minor test issues: > EmbeddedPigScriptTest tests needs some more time on windows for oozie job creation > FeedInstanceStatusTest should have used coloname - (getColo call returns something else) > PrismFeedUpdateTest#dependentProcessSucceeded should have used cluster1's oozie client instead of prism(which has no oozie client associated with it) > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java ec8726c > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 806bbd3 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 99ffe37 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 3b3ba71 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 55d69a3 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java a07161d > > Diff: https://reviews.apache.org/r/26297/diff/ > > > Testing > ------- > > Modified EmbeddedPigScriptTest > FeedInstanceStatusTest > > > Thanks, > > Raghav Gautam > > --===============4434442942334184948==--