falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Re: Review Request 27280: https://issues.apache.org/jira/browse/FALCON-618
Date Thu, 30 Oct 2014 08:42:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27280/#review59148
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100469>

    checkstyle:
    should be 'LOGGER'



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100466>

    checkstyle:
    Variable ... must be private ...



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100467>

    checkstyle:
    'private' modifier out of order with the JLS suggestions.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100464>

    do you use our checkstyle config from checkstyle subproject? I have this error found by
checkstyle:
    
    '(' should be on the previous line. (222:17)



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100465>

    checkstyle:
    '(' should be on the previous line. (233:29)



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
<https://reviews.apache.org/r/27280/#comment100470>

    checkstyle:
    whitespace expected before '//'


- Ruslan Ostafiychuk


On Oct. 28, 2014, 1:15 p.m., samarth gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27280/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 1:15 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/FALCON-618
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
02f572e 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
dab5d2c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
024a652 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java
86d4d47 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
c6217c1 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java
d4f31e9 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java
f564bb4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
a94cf1a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
3f7258e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
9b5d770 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/process-agg.xml
03cb727 
> 
> Diff: https://reviews.apache.org/r/27280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> samarth gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message