falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 26544: FALCON-762
Date Tue, 14 Oct 2014 19:01:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56560
-----------------------------------------------------------



webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/26544/#comment96907>

    One more minor nit, actual expression should be first argument and expected should be
second argument. It's currently wrong in entire file but may be we can start with this test
to correct it.


- Ajay Yadava


On Oct. 13, 2014, 10:53 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:53 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION

>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b

>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713

>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e

>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message