falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruslan Ostafiychuk" <rostafiyc...@hortonworks.com>
Subject Re: Review Request 26110: Add ACL validation and enforcement tests
Date Tue, 07 Oct 2014 11:17:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26110/#review55643
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java
<https://reviews.apache.org/r/26110/#comment96004>

    If ArrayUtils.isEmpty() == true then Arrays.deepToString() will return 'null' or '[]'.
I think 'arrX can't be empty' is enough.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java
<https://reviews.apache.org/r/26110/#comment96005>

    we can use ArrayUtils here:
    return ArrayUtils.addAll(arr1, arr2);
    
    or we can use that method instead of new 'append()'


- Ruslan Ostafiychuk


On Oct. 3, 2014, 7:44 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26110/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 7:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-746
>     https://issues.apache.org/jira/browse/falcon-746
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add ACL validation and enforcement tests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 659657c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
33b67f7 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
025fc15 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
a10dfc1 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
eac3cb4 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
3a56530 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java
66a1b7f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java
PRE-CREATION 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java
d8ac903 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java
bf99291 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java
1bbe8d9 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
30eaf61 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26110/diff/
> 
> 
> Testing
> -------
> 
> Adding new tests.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message