Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CFF311589 for ; Mon, 8 Sep 2014 11:44:06 +0000 (UTC) Received: (qmail 34864 invoked by uid 500); 8 Sep 2014 11:44:05 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 34819 invoked by uid 500); 8 Sep 2014 11:44:05 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 34808 invoked by uid 99); 8 Sep 2014 11:44:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 11:44:05 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Sep 2014 11:43:43 +0000 Received: (qmail 33695 invoked by uid 99); 8 Sep 2014 11:43:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 11:43:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD9871DD4F9; Mon, 8 Sep 2014 11:43:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8294487704477825954==" MIME-Version: 1.0 Subject: Re: Review Request 25425: FALCON-677. Feed data and stats path defaults to /tmp/ From: shwetha.gs@inmobi.com To: shwetha.gs@inmobi.com Cc: "Suhas Vasu" , "Falcon" Date: Mon, 08 Sep 2014 11:43:39 -0000 Message-ID: <20140908114339.23923.19351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/25425/ X-Sender: noreply@reviews.apache.org References: <20140908070211.23924.91336@reviews.apache.org> In-Reply-To: <20140908070211.23924.91336@reviews.apache.org> Reply-To: shwetha.gs@inmobi.com X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============8294487704477825954== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25425/#review52583 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java Use StringUtils.equals which handles null common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java return null for location - shwethags On Sept. 8, 2014, 7:02 a.m., Suhas Vasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25425/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 7:02 a.m.) > > > Review request for Falcon and shwethags. > > > Repository: falcon-git > > > Description > ------- > > If a feed does not have stats path specified, it assumes it as /tmp/ on the hdfs. Ideally we should be throwing an error that the specified feed does not have a stats path. > > Users may have specified to delete the stats path if it exists, in the prepare tag in workflow. In such a scenario the whole of /tmp/ is cleared, which is totally undesirable. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 > common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java a78c678 > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java 1fa6758 > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 23c01a9 > > Diff: https://reviews.apache.org/r/25425/diff/ > > > Testing > ------- > > > Thanks, > > Suhas Vasu > > --===============8294487704477825954==--