Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 766981130A for ; Sat, 6 Sep 2014 20:42:22 +0000 (UTC) Received: (qmail 55492 invoked by uid 500); 6 Sep 2014 20:42:22 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 55442 invoked by uid 500); 6 Sep 2014 20:42:22 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 55431 invoked by uid 99); 6 Sep 2014 20:42:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Sep 2014 20:42:21 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 06 Sep 2014 20:41:59 +0000 Received: (qmail 55394 invoked by uid 99); 6 Sep 2014 20:41:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Sep 2014 20:41:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8ACF81DBD1E; Sat, 6 Sep 2014 20:41:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3122356637832415867==" MIME-Version: 1.0 Subject: Re: Review Request 25211: Delegated feed eviction to the appropriate Storage implementation From: "Ajay Yadava" To: shwetha.gs@inmobi.com Cc: "Falcon" , "Ajay Yadava" Date: Sat, 06 Sep 2014 20:41:56 -0000 Message-ID: <20140906204156.13427.94145@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/25211/ X-Sender: "Ajay Yadava" References: <20140901133110.16961.63478@reviews.apache.org> In-Reply-To: <20140901133110.16961.63478@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============3122356637832415867== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25211/ ----------------------------------------------------------- (Updated Sept. 6, 2014, 8:41 p.m.) Review request for Falcon and shwethags. Repository: falcon-git Description ------- Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage. Corresponding code was being called using an if else. To make the code cleaner and more manageable I moved the code to the appropriate storage class and delegated feed eviction to the appropriate Storage implementation. Needed to add evict method to Storage Interface and make some minor changes here and there. Diffs (updated) ----- common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 common/src/main/java/org/apache/falcon/retention/EvictionHelper.java 5d6481c retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 114071f Diff: https://reviews.apache.org/r/25211/diff/ Testing ------- All FeedEvictor tests passed. Thanks, Ajay Yadava --===============3122356637832415867==--