Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8034469132570165157=="
MIME-Version: 1.0
Subject: Re: Review Request 25211: Delegated feed eviction to the appropriate
 Storage implementation
From: shwetha.gs@inmobi.com
To: shwetha.gs@inmobi.com
Cc: "Falcon" <dev@falcon.incubator.apache.org>,
 "Ajay Yadava" <ajaynsit@gmail.com>
Date: Mon, 01 Sep 2014 06:28:03 -0000
Message-ID: <20140901062803.16961.91418@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: noreply@reviews.apache.org
References: <20140830072240.17468.42667@reviews.apache.org>
In-Reply-To: <20140830072240.17468.42667@reviews.apache.org>
Reply-To: shwetha.gs@inmobi.com

--===============8034469132570165157==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25211/#review51970
-----------------------------------------------------------


common/src/main/java/org/apache/falcon/entity/Storage.java
<https://reviews.apache.org/r/25211/#comment90691>

    shoudl throw only FalconException


move the corresponding UTs as well

- shwethags


On Aug. 30, 2014, 7:22 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25211/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 7:22 a.m.)
> 
> 
> Review request for Falcon and shwethags.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage. Corresponding code was being called using an if else. To make the code cleaner and more manageable I moved the code to the appropriate storage class and delegated feed eviction to the appropriate Storage implementation. Needed to add evict method to Storage Interface and make some minor changes here and there.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 4de7938 
> 
> Diff: https://reviews.apache.org/r/25211/diff/
> 
> 
> Testing
> -------
> 
> All FeedEvictor tests passed.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


--===============8034469132570165157==--