falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-665) Handle message consumption failures in JMSMessageConsumer
Date Thu, 11 Sep 2014 05:37:33 GMT

    [ https://issues.apache.org/jira/browse/FALCON-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129656#comment-14129656
] 

Shwetha G S commented on FALCON-665:
------------------------------------

{quote}
Pls look at the code again, ack is done right after consumption and if there was an exception,
it would not come to ack but goes to catch clause
{quote}
{code}
WorkflowJobEndNotificationService:
    public void notifySuccess(WorkflowExecutionContext context) throws FalconException {
        for (WorkflowExecutionListener listener : listeners) {
            try {
                listener.onSuccess(context);
            } catch (Throwable t) {
                // do not rethrow as other listeners do not get a chance
                LOG.error("Error in listener {}", listener.getClass().getName(), t);
            }
        }

        instrumentAlert(context);
    }
{code}
None of the exceptions from listeners are thrown back, how will the control go to onMessage()
catch block?

{quote}
Nope. This is not possible since there are folks using other MQ brokers and breaks compatibility.
{quote}
CLIENT_ACKNOWLEDGE doesn't work for us. Read this from config which others can configure depending
on the jms implementation they use? For activemq, it should be INDIVIDUAL_ACKNOWLEDGE


> Handle message consumption failures in JMSMessageConsumer
> ---------------------------------------------------------
>
>                 Key: FALCON-665
>                 URL: https://issues.apache.org/jira/browse/FALCON-665
>             Project: Falcon
>          Issue Type: Improvement
>          Components: messaging
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Priority: Critical
>             Fix For: 0.6
>
>         Attachments: FALCON-665-review.patch, FALCON-665-v1.patch
>
>
> Not sure which Queue ([~shwethags], [~shaik.idris])?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message