falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-661) Add list types API
Date Wed, 03 Sep 2014 23:29:51 GMT

    [ https://issues.apache.org/jira/browse/FALCON-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120671#comment-14120671
] 

Venkatesh Seetharam commented on FALCON-661:
--------------------------------------------

Looks good. Couple minor nits:

* MetadataMappingResource to MetadataDiscoveryResource?
* Why is it expending LineageMetadataResource? Can you not move a single method into GraphUtils?
* Replace static clas name in testContext.PROCESS_ENTITY_NAME

* org.apache.falcon.resource.metadata.MetadataMappingResource#parseDimensionType
Why a for loop? You can construct the enum as: RelationshipType.valueOf(type.toUpperCase())

* org.apache.falcon.resource.metadata.MetadataMappingResource#listDimensions
It should be listDimensionValues()

*             if (isVertexRelatedToCluster(relationshipType, vertex, clusterName)) {
clusterName is not checked for valid input

*             JSONObject response = buildJSONResponse(vertexes);
Do we need a response of vertices or just string names?

* org.apache.falcon.resource.metadata.MetadataMappingResource#isVertexRelatedToCluster
Cluster type is not useful no?
The traversal is quite inefficient. Can we not combine the query into a VertexQuery instead
of looping thru the results.


> Add list types API
> ------------------
>
>                 Key: FALCON-661
>                 URL: https://issues.apache.org/jira/browse/FALCON-661
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Balu Vellanki
>              Labels: lineage
>         Attachments: Falcon-Jira-661-v1.patch, Falcon-Jira-661.patch
>
>
> {noformat}
> GET http://host/graphs/lineage/$type/list?$optional_cluster_name=foo
> $type as in org.apache.falcon.metadata.RelationshipType
> except instance vertex types
> Examples:
> List all feed entities
> GET http://host/graphs/lineage/feed/list
> List all feed entities for a given cluster
> GET http://host/graphs/lineage/feed/list?cluster_name=foo_cluster
> GET http://host/graphs/lineage/cluster/list
> GET http://host/graphs/lineage/process/list
> GET http://host/graphs/lineage/users/list
> GET http://host/graphs/lineage/colo/list
> GET http://host/graphs/lineage/tags/list
> GET http://host/graphs/lineage/groups/list
> GET http://host/graphs/lineage/pipelines/list
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message