falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suma Shivaprasad" <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 26096: FALCON-301 Disallow feeds with same location
Date Tue, 30 Sep 2014 07:12:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26096/#review54957
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java
<https://reviews.apache.org/r/26096/#comment95287>

    Also delete check for boolean is missing in all places



common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java
<https://reviews.apache.org/r/26096/#comment95288>

    delete result (boolean) check is missing in all calls


- Suma Shivaprasad


On Sept. 26, 2014, 8:34 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26096/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 8:34 p.m.)
> 
> 
> Review request for Falcon and Srikanth Sundarrajan.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-301 Disallow feeds with same location
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/store/FeedLocationStore.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/entity/store/LocationStore.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/util/KeyAlreadyExistsException.java PRE-CREATION

>   common/src/main/java/org/apache/falcon/util/RadixNode.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/util/RadixTree.java PRE-CREATION 
>   common/src/main/resources/startup.properties e233b2a 
>   common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 2140335 
>   common/src/test/java/org/apache/falcon/entity/store/FeedLocationStoreTest.java PRE-CREATION

>   common/src/test/java/org/apache/falcon/group/FeedGroupMapTest.java a6c52e3 
>   common/src/test/java/org/apache/falcon/util/RadixNodeTest.java PRE-CREATION 
>   common/src/test/java/org/apache/falcon/util/RadixTreeTest.java PRE-CREATION 
>   src/conf/startup.properties 78466af 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java cb0dd2d 
>   webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 0f2a971 
>   webapp/src/test/java/org/apache/falcon/process/TableStorageProcessIT.java 51afbb8 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java ed70a0b

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java d4a1d8a

>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerPaginationJerseyIT.java
bd68e57 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 5249888

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java e9545d1 
>   webapp/src/test/resources/feed-template1.xml 456f7ce 
>   webapp/src/test/resources/feed-template2.xml d4901fa 
> 
> Diff: https://reviews.apache.org/r/26096/diff/
> 
> 
> Testing
> -------
> 
> Yes. Unit Tests are present for new classes and all unit & integration tests pass.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message