falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 25211: Delegated feed eviction to the appropriate Storage implementation
Date Thu, 25 Sep 2014 08:18:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25211/#review54525
-----------------------------------------------------------

Ship it!


Ship It!

- Srikanth Sundarrajan


On Sept. 16, 2014, 11:25 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25211/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 11:25 a.m.)
> 
> 
> Review request for Falcon and shwethags.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage.
Corresponding code was being called using an if else. To make the code cleaner and more manageable
I moved the code to the appropriate storage class and delegated feed eviction to the appropriate
Storage implementation. Needed to add evict method to Storage Interface and make some minor
changes here and there.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/retention/EvictionHelper.java 5d6481c 
>   retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 114071f 
> 
> Diff: https://reviews.apache.org/r/25211/diff/
> 
> 
> Testing
> -------
> 
> All FeedEvictor tests passed.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message