falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samarth gupta" <samarthgupta...@gmail.com>
Subject Re: Review Request 25294: Patch for late data regression test for feed and process
Date Tue, 23 Sep 2014 05:41:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25294/#review54243
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
<https://reviews.apache.org/r/25294/#comment94251>

    have a common OozieClient variable at start of method in place of calling "helper.getClusterHelper().getOozieClient()"
 every time.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94252>

    log statement can be removed. I think we already print entity definition before submit
and schedule.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94253>

    Util.readEntityName(feed); is called multiple times in same test. Name value can be save
in a variable and used at other places instead of calling funtion every time.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/25294/#comment94262>

    why are we doing source.substring(26) ?


- samarth gupta


On Sept. 18, 2014, 12:47 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25294/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 12:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Late data regression test for feed and process
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java
922c030 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java
806bbd3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
197c3c6 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
7a5a91e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
378cbbd 
>   falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/InputFeed.xml PRE-CREATION

>   falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml
PRE-CREATION 
>   falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/FETL-BillingRC.xml
eb31839 
>   falcon-regression/merlin/src/test/resources/LocalDC_feedReplicaltion_BillingRC/cluster-0.1.xml
afa86c4 
> 
> Diff: https://reviews.apache.org/r/25294/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Added new patch
>   https://reviews.apache.org/media/uploaded/files/2014/09/05/40eb0679-7e78-44f0-a023-523ca7cc45cc__FALCON-631-v2.patch
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message