falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 25777: [FALCON-743]Adding tests for cases related to usage of pipelines tag
Date Thu, 18 Sep 2014 18:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25777/#review53838
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
<https://reviews.apache.org/r/25777/#comment93696>

    StringUtils.isEmpty() ?



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
<https://reviews.apache.org/r/25777/#comment93695>

    I think this method can be simplified by using library methods. See StringUtils.join()
usage in OSUtil class.



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java
<https://reviews.apache.org/r/25777/#comment93698>

    I think pipeline tags are not applicable for all entities - probably clusters and feeds.
For ClusterEntityHelperImpl and DataEntityHelperImpl you might want to override this method
to throw UnsupportedOperationException.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
<https://reviews.apache.org/r/25777/#comment93704>

    initial value of testDir should probably be "/ProcessPipelineTest"



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
<https://reviews.apache.org/r/25777/#comment93708>

    See if you can make getListByPipeline to return EntitiesResult by pushing unmarshalling
operations into it.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
<https://reviews.apache.org/r/25777/#comment93709>

    deleteByName can throw exception and abort your loop.


- Raghav Gautam


On Sept. 18, 2014, 6:15 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25777/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 6:15 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-743
>     https://issues.apache.org/jira/browse/FALCON-743
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> New test cases according to pipelines tagging enhancement
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
48ee049 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
6d8b032 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java
7f8ac6a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25777/diff/
> 
> 
> Testing
> -------
> 
> listPipelineSpecialName() and listPipelineUTF8Name() are failing and are discussed now
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message