falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Isaychuk" <pisayc...@hortonworks.com>
Subject Re: Review Request 25446: [FALCON-693] Tests with zero inp/outp fixed to use correct workflow, javadocs added
Date Tue, 09 Sep 2014 15:16:31 GMT


> On Sept. 8, 2014, 11:31 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java,
line 68
> > <https://reviews.apache.org/r/25446/diff/1/?file=682653#file682653line68>
> >
> >     Why have we changed the workflow that was being used ? And in case we want to
do that then we can get rid of aggregateWorkflowDir field.

Sure, removed this variable in updated patch. As for new workflow, process fails with old
one because seems like it tries to use input/output variables which can't be used when they
are absent in process. I pointed it in https://hortonworks.jira.com/browse/BUG-21824.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25446/#review52653
-----------------------------------------------------------


On Sept. 9, 2014, 3:13 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25446/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 3:13 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-693
>     https://issues.apache.org/jira/browse/FALCON-693
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Tests with zero inp/outp fixed to use correct workflow, javadocs added
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
638768d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
9c71375 
> 
> Diff: https://reviews.apache.org/r/25446/diff/
> 
> 
> Testing
> -------
> 
> Tested.
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message