falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suhas Vasu" <suhas....@gmail.com>
Subject Re: Review Request 25425: FALCON-677. Feed data and stats path defaults to /tmp/
Date Tue, 09 Sep 2014 12:01:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25425/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 12:01 p.m.)


Review request for Falcon and shwethags.


Repository: falcon-git


Description
-------

If a feed does not have stats path specified, it assumes it as /tmp/ on the hdfs. Ideally
we should be throwing an error that the specified feed does not have a stats path.

Users may have specified to delete the stats path if it exists, in the prepare tag in workflow.
In such a scenario the whole of /tmp/ is cleared, which is totally undesirable.


Diffs (updated)
-----

  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 323188d 
  common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 
  common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 8fd56e1 
  common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java a78c678 
  oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java
1fa6758 
  oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
23c01a9 

Diff: https://reviews.apache.org/r/25425/diff/


Testing
-------


Thanks,

Suhas  Vasu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message