falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 25211: Delegated feed eviction to the appropriate Storage implementation
Date Mon, 01 Sep 2014 06:28:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25211/#review51970
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/Storage.java
<https://reviews.apache.org/r/25211/#comment90691>

    shoudl throw only FalconException


move the corresponding UTs as well

- shwethags


On Aug. 30, 2014, 7:22 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25211/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 7:22 a.m.)
> 
> 
> Review request for Falcon and shwethags.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage.
Corresponding code was being called using an if else. To make the code cleaner and more manageable
I moved the code to the appropriate storage class and delegated feed eviction to the appropriate
Storage implementation. Needed to add evict method to Storage Interface and make some minor
changes here and there.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 4de7938 
> 
> Diff: https://reviews.apache.org/r/25211/diff/
> 
> 
> Testing
> -------
> 
> All FeedEvictor tests passed.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message