falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-166) Instance status start and end dates are rigid and inconvenient
Date Mon, 25 Aug 2014 21:29:00 GMT

    [ https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109770#comment-14109770

Balu Vellanki commented on FALCON-166:

Based on the feedback received, here is the updated task description. 

1. Both startDate and endDate are optional. If startDate is empty, defaults to startDate of
the entity
2. If startDate is set before start of entity, startDate will be reset to entity's start time.

3. If endDate is empty, it defaults to max of  (startDate + 10 * frequency * frequencyTimeUnit)
OR (currentTimestamp).  This will fetch 10 instances (if they are scheduled). This will ensure
there is large enough time window to get some instances. 
4. If endDate is set to be after end of entity, endDate is reset to entity's end time. 
5. An exception will be thrown only when endDate is set to time older than startDate. No exceptions
will be thrown in other cases.

Example : To get 10 latest instances that succeeded

GET http://localhost:15000/api/instance/status/process/SampleProcess?colo=*&filterBy=STATUS:SUCCEEDED&orderBy=startTime&offset=0&numResults=10

6. numResults defaults to "-1", which means return all instances. 
7. Returned instances can be ordered by "status","cluster" (default sort order is ascending)
and "starttime","endtime"  (default sort order is descending). 
8. Option param sort order will be implemented under separate JIRA https://issues.apache.org/jira/browse/FALCON-640


> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>                 Key: FALCON-166
>                 URL: https://issues.apache.org/jira/browse/FALCON-166
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Balu Vellanki
>             Fix For: 0.6
>         Attachments: Falcon-Jira-166-v1.patch, Falcon-Jira-166-v2.patch, Falcon-Jira-166.patch
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while working
on FALCON-164. The use case is to get the status for a given entity for the past 1 or 2 or
3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the start date
which is too small a window.
> {code}
>     private Date getEndDate(Date start, String endStr) throws FalconException {
>         Date end;
>         if (StringUtils.isEmpty(endStr)) {
>             end = new Date(start.getTime() + 1000); // next sec
>         } else {
>             end = EntityUtil.parseDateUTC(endStr);
>         }
>         return end;
>     }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date for looking
at the instances in the past 7 days, it should fetch what is valid rather than complain that
the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure what the performance
impact is for this API to be changed.
> Thoughts? 

This message was sent by Atlassian JIRA

View raw message