falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadav (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-166) Instance status start and end dates are rigid and inconvenient
Date Wed, 27 Aug 2014 19:13:58 GMT

    [ https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112666#comment-14112666
] 

Ajay Yadav commented on FALCON-166:
-----------------------------------

Hi [~bvellanki]

>From the details given in above comment, I think assuming default start time as end -
10 * entityFrequency might be inconvenient in some use cases. 

Case 1: If I specify number of results as 20 and don't specify start time, from above details
it seems that the number of results returned will still be 10 (as start time will be default)

Case 2: If I don't specify number of results, and it defaults to 10, showing second page results
will be tricky.

Hence my original suggestion, that start time should be defaulted to the first start time
of the entity(first instance). Hence 

- start time should be optional and default to start time of the entity(first instance)


 



> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
>                 Key: FALCON-166
>                 URL: https://issues.apache.org/jira/browse/FALCON-166
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Balu Vellanki
>             Fix For: 0.6
>
>         Attachments: Falcon-Jira-166-v1.patch, Falcon-Jira-166-v2.patch, Falcon-Jira-166-v3.patch,
Falcon-Jira-166-v4.patch, Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while working
on FALCON-164. The use case is to get the status for a given entity for the past 1 or 2 or
3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the start date
which is too small a window.
> {code}
>     private Date getEndDate(Date start, String endStr) throws FalconException {
>         Date end;
>         if (StringUtils.isEmpty(endStr)) {
>             end = new Date(start.getTime() + 1000); // next sec
>         } else {
>             end = EntityUtil.parseDateUTC(endStr);
>         }
>         return end;
>     }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date for looking
at the instances in the past 7 days, it should fetch what is valid rather than complain that
the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure what the performance
impact is for this API to be changed.
> Thoughts? 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message