falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-166) Instance status start and end dates are rigid and inconvenient
Date Mon, 25 Aug 2014 05:55:58 GMT

    [ https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108773#comment-14108773
] 

Shwetha G S commented on FALCON-166:
------------------------------------

The most common usecase for any instance commands is to look at the latest instances. We should
make sure that the user has to set very less params to get this data. The way we can do it
is by setting:
1. start as optional with default process start
2. end as optional with default current timestamp
3. sort order as optional with default desc
4. len as optional with default 10/100
5. offset as optional with default 0 (used for pagination)

{quote}
if the start date is way in the past, setting default end date to now might make query to
the workflow scheduler expensive.
{quote}
All these params map 1 to 1 with oozie APIs and they are optimised. They are sent as is to
oozie db query as where conditions and only the final set is processed by oozie.


> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
>                 Key: FALCON-166
>                 URL: https://issues.apache.org/jira/browse/FALCON-166
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Balu Vellanki
>             Fix For: 0.6
>
>         Attachments: Falcon-Jira-166-v1.patch, Falcon-Jira-166-v2.patch, Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while working
on FALCON-164. The use case is to get the status for a given entity for the past 1 or 2 or
3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the start date
which is too small a window.
> {code}
>     private Date getEndDate(Date start, String endStr) throws FalconException {
>         Date end;
>         if (StringUtils.isEmpty(endStr)) {
>             end = new Date(start.getTime() + 1000); // next sec
>         } else {
>             end = EntityUtil.parseDateUTC(endStr);
>         }
>         return end;
>     }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date for looking
at the instances in the past 7 days, it should fetch what is valid rather than complain that
the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure what the performance
impact is for this API to be changed.
> Thoughts? 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message